]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: sdhci: improve ADMA error reporting
authorRussell King <rmk+kernel@armlinux.org.uk>
Sun, 22 Sep 2019 10:26:53 +0000 (11:26 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 27 Sep 2019 18:30:13 +0000 (20:30 +0200)
commitf1a5359cf6934f390d477452b74b486b1e06e7b2
treebb9f00e274d2a1c74cb86badd55935f1947d9dd4
parentd6a70541012e32f0ff070638af25be05743e556b
mmc: sdhci: improve ADMA error reporting

ADMA errors are potentially data corrupting events; although we print
the register state, we do not usefully print the ADMA descriptors.
Worse than that, we print them by referencing their virtual address
which is meaningless when the register state gives us the DMA address
of the failing descriptor.

Print the ADMA descriptors giving their DMA addresses rather than their
virtual addresses, and print them using SDHCI_DUMP() rather than DBG().

We also do not show the correct value of the interrupt status register;
the register dump shows the current value, after we have cleared the
pending interrupts we are going to service.  What is more useful is to
print the interrupts that _were_ pending at the time the ADMA error was
encountered.  Fix that too.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci.c