]> git.baikalelectronics.ru Git - kernel.git/commit
s390/3270: fix allocation of tty3270_screen structure
authorMartin Schwidefsky <schwidefsky@de.ibm.com>
Wed, 18 Dec 2013 13:36:18 +0000 (14:36 +0100)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Wed, 18 Dec 2013 16:35:30 +0000 (17:35 +0100)
commitf16c1cdabfa9dd06fbe2820af0012d1192bf78cc
treea6397bfe3a41e04a69fb79a9e24f9ee55475d0bd
parentafb58234f90b6ab70dcb13ea9046ab33d3a40edb
s390/3270: fix allocation of tty3270_screen structure

The tty3270_alloc_screen function is called from tty3270_install with
swapped arguments, the number of columns instead of rows and vice versa.
The number of rows is typically smaller than the number of columns which
makes the screen array too big but the individual cell arrays for the
lines too small. Creating lines longer than the number of rows will
clobber the memory after the end of the cell array.
The fix is simple, call tty3270_alloc_screen with the correct argument
order.

Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/char/tty3270.c