]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: pch_dma: use tasklet_kill in teardown
authorVinod Koul <vinod.koul@intel.com>
Thu, 6 Mar 2014 06:54:08 +0000 (12:24 +0530)
committerVinod Koul <vinod.koul@intel.com>
Mon, 17 Mar 2014 13:04:11 +0000 (18:34 +0530)
commitf14a9a43634e975250b9064f4a7a1fc5f1d3b58f
tree80cd2c7749716c1483d2a45bca232587407cd98d
parent3e11d60297f71dc37f4ae4b405d38f9b0ecfe60d
dmaengine: pch_dma: use tasklet_kill in teardown

As discussed in [1] the tasklet_disable is not a proper function for teardown.
We need to ensure irq is disabled, followed by ensuring that don't schedule any
more tasklets and then its safe to use tasklet_kill().

Here in pch dma driver we need to use free_irq() before tasklet_kill(). So move
up the free_irq() which will ensure that the irq is disabled and also wait till
all scheduled interrupts are executed by invoking synchronize_irq().

[1]: http://lwn.net/Articles/588457/

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/pch_dma.c