]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: PPC: Book3S HV: fix incorrect NULL check on list iterator
authorXiaomeng Tong <xiam0nd.tong@gmail.com>
Thu, 14 Apr 2022 06:21:03 +0000 (14:21 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 18 May 2022 13:31:35 +0000 (23:31 +1000)
commitf0ef972d46d1e977aaf0ceede17867d2555ad3b3
treec63a5d60a31097ba4e18d34a2bd1906f67b43398
parent25e45e44f95b2279f37420538fc860e284d4d29f
KVM: PPC: Book3S HV: fix incorrect NULL check on list iterator

The bug is here:
if (!p)
                return ret;

The list iterator value 'p' will *always* be set and non-NULL by
list_for_each_entry(), so it is incorrect to assume that the iterator
value will be NULL if the list is empty or no element is found.

To fix the bug, Use a new value 'iter' as the list iterator, while use
the old value 'p' as a dedicated variable to point to the found element.

Fixes: 7d57ac025eeb ("KVM: PPC: Book3S HV: In H_SVM_INIT_DONE, migrate remaining normal-GFNs to secure-GFNs")
Cc: stable@vger.kernel.org # v5.9+
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220414062103.8153-1-xiam0nd.tong@gmail.com
arch/powerpc/kvm/book3s_hv_uvmem.c