]> git.baikalelectronics.ru Git - kernel.git/commit
drm/sched: fix the bug of time out calculation(v4)
authorMonk Liu <Monk.Liu@amd.com>
Wed, 1 Sep 2021 00:46:46 +0000 (08:46 +0800)
committerAndrey Grodzovsky <andrey.grodzovsky@amd.com>
Wed, 15 Sep 2021 14:21:30 +0000 (10:21 -0400)
commitf0b9f7241184c805798e3998b252a076c89cf8af
tree20eb90439123abf55821c744dd05e7974206a743
parent470f2446f29c9dc8af3ec880f6184b3cb41f714b
drm/sched: fix the bug of time out calculation(v4)

issue:
in cleanup_job the cancle_delayed_work will cancel a TO timer
even the its corresponding job is still running.

fix:
do not cancel the timer in cleanup_job, instead do the cancelling
only when the heading job is signaled, and if there is a "next" job
we start_timeout again.

v2:
further cleanup the logic, and do the TDR timer cancelling if the signaled job
is the last one in its scheduler.

v3:
change the issue description
remove the cancel_delayed_work in the begining of the cleanup_job
recover the implement of drm_sched_job_begin.

v4:
remove the kthread_should_park() checking in cleanup_job routine,
we should cleanup the signaled job asap

TODO:
1)introduce pause/resume scheduler in job_timeout to serial the handling
of scheduler and job_timeout.
2)drop the bad job's del and insert in scheduler due to above serialization
(no race issue anymore with the serialization)

Tested-by: jingwen <jingwen.chen@@amd.com>
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1630457207-13107-1-git-send-email-Monk.Liu@amd.com
drivers/gpu/drm/scheduler/sched_main.c