]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl: aspeed-g5: Fix pin association of SPI1 function
authorAndrew Jeffery <andrew@aj.id.au>
Tue, 27 Sep 2016 14:50:16 +0000 (00:20 +0930)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 18 Oct 2016 12:36:12 +0000 (14:36 +0200)
commitf0775d6c32d9d3e118b3c3ab0fb946db8ed4786d
tree1b3d9321b8fdc248d6ec3ae994d862370772ec19
parent9419e14eccaa3228d56fcc423b0cd8509a4f5000
pinctrl: aspeed-g5: Fix pin association of SPI1 function

The SPI1 function was associated with the wrong pins: The functions that
those pins provide is either an SPI debug or passthrough function
coupled to SPI1. Make the SPI1 mux function configure the relevant pins
and associate new SPI1DEBUG and SPI1PASSTHRU functions with the pins
that were already defined.

The notation used in the datasheet's multi-function pin table for the SoC is
often creative: in this case the SYS* signals are enabled by a single bit,
which is nothing unusual on its own, but in this case the bit was also
participating in a multi-bit bitfield and therefore represented multiple
functions. This fact was overlooked in the original patch.

Fixes: 4666b756f753 (pinctrl: Add pinctrl-aspeed-g5 driver)
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt
drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c