]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Don't clobber M/N values during fastset check
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 12 Jun 2019 17:24:23 +0000 (20:24 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 18 Jun 2019 15:28:51 +0000 (18:28 +0300)
commitf0521558a2a89d58a08745e225025d338572e60a
treed2a71ad5fdb8bf0a30d876cfc6aa188f3f816f63
parentef78f7b18726578fbabdeb8719f161f48a34d85d
drm/i915: Don't clobber M/N values during fastset check

We're now calling intel_pipe_config_compare(..., true) uncoditionally
which means we're always going clobber the calculated M/N values with
the old values if the fuzzy M/N check passes. That causes problems
because the fuzzy check allows for a huge difference in the values.

I'm actually tempted to just make the M/N checks exact, but that might
prevent fastboot from kicking in when people want it. So for now let's
overwrite the computed values with the old values only if decide to skip
the modeset.

v2: Copy has_drrs along with M/N M2/N2 values

Cc: stable@vger.kernel.org
Cc: Blubberbub@protonmail.com
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Tested-by: Blubberbub@protonmail.com
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110782
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110675
Fixes: d19f958db23c ("drm/i915: Enable fastset for non-boot modesets.")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190612172423.25231-1-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/display/intel_display.c