]> git.baikalelectronics.ru Git - kernel.git/commit
max8903: cleans up confusing relationship between dc_valid, dok and dcm.
authorChris Lapa <chris@lapa.com.au>
Fri, 24 Jun 2016 02:26:08 +0000 (12:26 +1000)
committerSebastian Reichel <sre@kernel.org>
Tue, 28 Jun 2016 18:05:41 +0000 (20:05 +0200)
commitf02ed43d2599c9c21169f943ec2ba5846b4ac0b4
tree04a3c100d0f13dfcee5e9105349ff6d079a506b8
parenta20cfe5ce82c37cc9f2d795f0eed2f6a1bb9f6f7
max8903: cleans up confusing relationship between dc_valid, dok and dcm.

The max8903_charger.h file indicated that dcm and dok were not optional
when dc_valid is set.

It makes sense to have dok as a compulsory pin when dc_valid is given.
However dcm can be optionally wired to a fixed level especially when the
circuit is configured for dc power exclusively.

The previous implementation already allowed for this somewhat, however no
error was given if dok wasn't given whilst dc_valid was.

The new implementation enforces dok presence when dc_valid is given. Whilst
allowing dcm to be optional.

Signed-off-by: Chris Lapa <chris@lapa.com.au>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/max8903_charger.c
include/linux/power/max8903_charger.h