]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ALSA: hda - Allow power_save_controller option override DCAPS"
authorTakashi Iwai <tiwai@suse.de>
Thu, 4 Apr 2013 13:35:24 +0000 (15:35 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 4 Apr 2013 13:35:39 +0000 (15:35 +0200)
commitefbc75587b40e4b50075c4afda85fdde1b62feac
treeae99f026484bbd912abfed8fb5e565f5a3a7a900
parent5edc42c7b2ac7f060cc1a828d7c76e251136afb1
Revert "ALSA: hda - Allow power_save_controller option override DCAPS"

This reverts commit 12a5ca9b81720ef79965a7a414957307723148d1.

The commit [12a5ca9b81: ALSA: hda - Allow power_save_controller option
override DCAPS] changed the behavior of power_save_controller so that
it can override the driver capability.  This assumed that this option
is rarely changed dynamically unlike power_save option.  Too naive.

It turned out that the user-space power-management tool tries to set
power_save_controller option to 1 together with power_save option
without knowing what's actually doing.  This enabled forcibly the
runtime PM of the controller,  which is known to be broken om many
chips thus disabled as default.

So, the only sane fix is to revert this commit again.  It was intended
to ease debugging/testing for runtime PM enablement, but obviously we
need another way for it.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=56171
Reported-and-tested-by: Nikita Tsukanov <keks9n@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Documentation/sound/alsa/ALSA-Configuration.txt
sound/pci/hda/hda_intel.c