]> git.baikalelectronics.ru Git - kernel.git/commit
workqueues: do CPU_UP_CANCELED if CPU_UP_PREPARE fails
authorOleg Nesterov <oleg@tv-sign.ru>
Fri, 25 Jul 2008 08:47:54 +0000 (01:47 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 25 Jul 2008 17:53:41 +0000 (10:53 -0700)
commitef4f378eeab99ddc853cb08a5b4ed3e4b411da1a
tree964522eb36ea5424ece910092da5dce773c1f6cc
parent6ddcddbfe1596e0dea89295cfdd04e411c158142
workqueues: do CPU_UP_CANCELED if CPU_UP_PREPARE fails

The bug was pointed out by Akinobu Mita <akinobu.mita@gmail.com>, and this
patch is based on his original patch.

workqueue_cpu_callback(CPU_UP_PREPARE) expects that if it returns
NOTIFY_BAD, _cpu_up() will send CPU_UP_CANCELED then.

However, this is not true since

"cpu hotplug: cpu: deliver CPU_UP_CANCELED only to NOTIFY_OKed callbacks with CPU_UP_PREPARE"
commit: 1d3fcdc627fec8d4cc2b267886807d6cd6017ab4

The callback which has returned NOTIFY_BAD will not receive
CPU_UP_CANCELED.  Change the code to fulfil the CPU_UP_CANCELED logic if
CPU_UP_PREPARE fails.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Reported-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/workqueue.c