]> git.baikalelectronics.ru Git - kernel.git/commit
ARM/ARM64: arch-timer: fix arch_timer_probed logic
authorMarc Zyngier <marc.zyngier@arm.com>
Wed, 15 Oct 2014 15:06:20 +0000 (16:06 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Sun, 26 Oct 2014 19:50:00 +0000 (20:50 +0100)
commitef45bd088db707d9e145b6ff5f68f7b006faab77
tree8508fc927d835ce90fd5c7b920ddf185ce6246b4
parenta177393eae2c0ba3d2700cd95806b5255cd012cb
ARM/ARM64: arch-timer: fix arch_timer_probed logic

Commit 226c4c91e8ff (clocksource: arm_arch_timer: Discard unavailable
timers correctly) changed the way the driver makes sure both the memory
and system-register timers have been probed before finalizing the probing.

There is a interesting flaw in this logic that leads to this final step
never to be executed. Things seems to work pretty well until something
actually needs the data that is produced during this final stage.

For example, KVM explodes on the first run of a guest when executed on
a platform that has both memory and sysreg nodes (Juno, for example).

Just fix the damned logic, and enjoy booting VMs again.

Tested on a Juno system.

Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Christoffer Dall <christoffer.dall@linaro.org>
Reported-by: Riku Voipio <riku.voipio@linaro.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/arm_arch_timer.c