]> git.baikalelectronics.ru Git - kernel.git/commit
memcg: pin execution to current cpu while draining stock
authorJohannes Weiner <jweiner@redhat.com>
Thu, 25 Aug 2011 22:59:07 +0000 (15:59 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 25 Aug 2011 23:25:33 +0000 (16:25 -0700)
commitef37c1c4473fadb8ad8553e14d8b53eae5af978e
treee5e036671dc7ae02bebaf201126d6c19104e02d1
parent5fe032b68a141317a02f553f4c53277d32511e0a
memcg: pin execution to current cpu while draining stock

Commit 0deea1cf551e ("memcg do not try to drain per-cpu caches without
pages") added a drain_local_stock() call to a preemptible section.

The draining task looks up the cpu-local stock twice to set the
draining-flag, then to drain the stock and clear the flag again.  If the
task is migrated to a different CPU in between, noone will clear the
flag on the first stock and it will be forever undrainable.  Its charge
can not be recovered and the cgroup can not be deleted anymore.

Properly pin the task to the executing CPU while draining stocks.

Signed-off-by: Johannes Weiner <jweiner@redhat.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com
Acked-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/memcontrol.c