]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Improve debug Kconfig texts a bit
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 2 Jul 2021 20:17:08 +0000 (22:17 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 6 Jul 2021 08:10:07 +0000 (10:10 +0200)
commitef2e7b451e46b65ad6610520c8d9cc1be4e7bf79
treefcaac6c8447dbe6e257dae7e20e0cf22024057f0
parent90f35542b787bd5846d88054b346958bbbcba2d4
drm/i915: Improve debug Kconfig texts a bit

We're not consistently recommending these for developers only.

I stumbled over this due to DRM_I915_LOW_LEVEL_TRACEPOINTS, which was
added in

commit 977334807c7f59033cc1ec5b48bc4050b8c5b05d
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date:   Tue Feb 21 11:01:42 2017 +0000

    drm/i915/tracepoints: Add request submit and execute tracepoints

to "alleviate the performance impact concerns."

Which is nonsense.

Tvrtko and Joonas pointed out on irc that the real (but undocumented
reason) was stable abi concerns for tracepoints, see

https://lwn.net/Articles/705270/

and the specific change that was blocked around tracepoints:

https://lwn.net/Articles/442113/

Anyway to make it a notch clearer why we have this Kconfig option
consistly add the "Recommended for driver developers only." to it and
all the other debug options we have.

Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210702201708.2075793-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/i915/Kconfig.debug