]> git.baikalelectronics.ru Git - kernel.git/commit
sfc: Fix null function pointer in efx_sriov_channel_type
authorBen Hutchings <bhutchings@solarflare.com>
Tue, 2 Oct 2012 00:43:45 +0000 (01:43 +0100)
committerBen Hutchings <bhutchings@solarflare.com>
Tue, 2 Oct 2012 00:57:25 +0000 (01:57 +0100)
commiteea32afc1e273bd62d3e38a5d3aeceab02ad0123
tree53765b1e20c178fcf762c9263746752121ec2405
parent4d5279854bf317a5ddc35f377b2f75831eda6e38
sfc: Fix null function pointer in efx_sriov_channel_type

Commit 725556c ('sfc: Add channel specific receive_skb handler and
post_remove callback') added the function pointer field
efx_channel_type::post_remove and an unconditional call through it.

This field should have been initialised to efx_channel_dummy_op_void
in the existing instances of efx_channel_type, but this was only done
in efx_default_channel_type.  Consequently, if a device has SR-IOV
enabled then removing the driver or device will result in an oops.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
drivers/net/ethernet/sfc/siena_sriov.c