]> git.baikalelectronics.ru Git - kernel.git/commit
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_reg_add
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 11 Apr 2018 01:15:31 +0000 (09:15 +0800)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Mon, 16 Apr 2018 14:20:45 +0000 (10:20 -0400)
commitee1dd6de2d1dc55974f4bd364349e128d97a7f4c
tree6a2e461e221e7cddc8f21923ce9deb8037b23d36
parentaaca2a5a92b9d6b6073235a8efdaca079feffed5
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_reg_add

pcistub_reg_add() is never called in atomic context.

pcistub_reg_add() is only called by pcistub_quirk_add, which is
only set in DRIVER_ATTR().

Despite never getting called from atomic context,
pcistub_reg_add() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/xen-pciback/pci_stub.c