]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Fix races in gen4 page flip interrupt handling
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 19 Feb 2013 13:16:39 +0000 (15:16 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 20 Feb 2013 14:03:16 +0000 (15:03 +0100)
commitee1166dda8cad404beac67d97a2bd71f05c4729f
tree7eb85c3179b6d68c5da36e5b00b6e0b5f5498d4c
parent8bceb7835d6cd0812ba208ffaea8f7887db527ee
drm/i915: Fix races in gen4 page flip interrupt handling

Use the gen3 logic for handling page flip interrupts on gen4.

Unfortuantely this kills the stall_check since that looks like it can
easily trigger too early. With the current logic the stall check would
kick in on the first vblank after the flip has been submitted to the
ring. If the CS takes longer than that to process the commands in the
ring, the stall check will cause the page flip to be complete too
early. That doesn't sound like a very good idea. Something better
should be deviced if we still need the stall check. For now, mark
i915_pageflip_stall_check() as unused.

v2: Fix irq enable_mask and add __always_unused (Chris Wilson)

References: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1116587
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_irq.c