]> git.baikalelectronics.ru Git - kernel.git/commit
spi: imx: Fix failure path leak on GPIO request error
authorTrent Piepho <tpiepho@impinj.com>
Tue, 31 Oct 2017 19:49:05 +0000 (12:49 -0700)
committerMark Brown <broonie@kernel.org>
Fri, 10 Nov 2017 21:28:10 +0000 (21:28 +0000)
commitece2336de9e6128d39b7ad63c31f52507166a993
treec0d85042521e6549a57bb189d522177e43f495a7
parent8dc99f657c2632ced492abb76617bebe0f8388c5
spi: imx: Fix failure path leak on GPIO request error

If the code that requests any chip select GPIOs fails, the cleanup of
spi_bitbang_start() by calling spi_bitbang_stop() is not done.  Add this
to the failure path.

Note that spi_bitbang_start() has to be called before requesting GPIOs
because the GPIO data in the spi master is populated when the master is
registed, and that doesn't happen until spi_bitbang_start() is called.

CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <kernel@pengutronix.de>
CC: Fabio Estevam <fabio.estevam@nxp.com>
CC: Mark Brown <broonie@kernel.org>
CC: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c