]> git.baikalelectronics.ru Git - kernel.git/commit
perf diff: Fix segfault on 'perf diff -o N' option
authorNamhyung Kim <namhyung@kernel.org>
Wed, 18 Jan 2017 05:14:56 +0000 (14:14 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 2 Feb 2017 14:39:04 +0000 (11:39 -0300)
commitec9616abc638f5c82c62ee841dfda9027766115c
tree10521265c230c18b407c0e4ffdecd528a16f072c
parent7b6362339197f3f9d112c9123a92994f40b8ff82
perf diff: Fix segfault on 'perf diff -o N' option

The -o/--order option is to select column number to sort a diff result.

It does the job by adding a hpp field at the beginning of the sort list.
But it should not be added to the output field list as it has no
callbacks required by a output field.

During the setup_sorting(), the perf_hpp__setup_output_field() appends
the given sort keys to the output field if it's not there already.

Originally it was checked by fmt->list being non-empty.  But commit
39721c45f513 ("perf hists: Make hpp setup function generic") changed it
to check the ->equal callback.

Anyways, we don't need to add the pseudo hpp field to the output field
list since it won't be used for output.  So just skip fields if they
have no ->color or ->entry callbacks.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Fixes: 39721c45f513 ("perf hists: Make hpp setup function generic")
Link: http://lkml.kernel.org/r/20170118051457.30946-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/hist.c