]> git.baikalelectronics.ru Git - kernel.git/commit
tun: fix return value when the number of iovs exceeds MAX_SKB_FRAGS
authorYunjian Wang <wangyunjian@huawei.com>
Fri, 25 Dec 2020 02:52:16 +0000 (10:52 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 28 Dec 2020 21:34:36 +0000 (13:34 -0800)
commitec4d571b1718a88e93af12a04df90587843c7017
tree53d48680489e76aa47314f02e854797d8e07fd86
parent4d2b0954f9ab8ef5f5eba97d9b0f849c08d2bd23
tun: fix return value when the number of iovs exceeds MAX_SKB_FRAGS

Currently the tun_napi_alloc_frags() function returns -ENOMEM when the
number of iovs exceeds MAX_SKB_FRAGS + 1. However this is inappropriate,
we should use -EMSGSIZE instead of -ENOMEM.

The following distinctions are matters:
1. the caller need to drop the bad packet when -EMSGSIZE is returned,
   which means meeting a persistent failure.
2. the caller can try again when -ENOMEM is returned, which means
   meeting a transient failure.

Fixes: dbb28a8499aa ("tun: enable napi_gro_frags() for TUN/TAP driver")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Link: https://lore.kernel.org/r/1608864736-24332-1-git-send-email-wangyunjian@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/tun.c