]> git.baikalelectronics.ru Git - kernel.git/commit
mm: filemap: fix mapping->nrpages double accounting in fuse
authorJohannes Weiner <hannes@cmpxchg.org>
Tue, 4 Oct 2016 14:58:06 +0000 (16:58 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 5 Oct 2016 16:17:56 +0000 (09:17 -0700)
commitec01b98b95c538cc78d27c47ab21bae961a94b30
tree68aa25b117a4dd307eb4923e02074f85a5c961f0
parent7018984ee659eb3a5e3791af1a377ca387b63fdf
mm: filemap: fix mapping->nrpages double accounting in fuse

Commit 209feb9e6ca0 ("mm: workingset: fix crash in shadow node shrinker
caused by replace_page_cache_page()") switched replace_page_cache() from
raw radix tree operations to page_cache_tree_insert() but didn't take
into account that the latter function, unlike the raw radix tree op,
handles mapping->nrpages.  As a result, that counter is bumped for each
page replacement rather than balanced out even.

The mapping->nrpages counter is used to skip needless radix tree walks
when invalidating, truncating, syncing inodes without pages, as well as
statistics for userspace.  Since the error is positive, we'll do more
page cache tree walks than necessary; we won't miss a necessary one.
And we'll report more buffer pages to userspace than there are.  The
error is limited to fuse inodes.

Fixes: 209feb9e6ca0 ("mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page()")
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/filemap.c