]> git.baikalelectronics.ru Git - kernel.git/commit
sctp: Allow struct sctp_event_subscribe to grow without breaking binaries
authorThomas Graf <tgraf@infradead.org>
Tue, 3 Apr 2012 22:17:53 +0000 (22:17 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Apr 2012 22:05:02 +0000 (18:05 -0400)
commiteb499389dc4e47921fdde11228b4d584034eccf9
treee06a7741371bb6905158fc70a3f05121e07f0306
parentd94cc7a44073d084f7c2ffe93efd9e4115642673
sctp: Allow struct sctp_event_subscribe to grow without breaking binaries

getsockopt(..., SCTP_EVENTS, ...) performs a length check and returns
an error if the user provides less bytes than the size of struct
sctp_event_subscribe.

Struct sctp_event_subscribe needs to be extended by an u8 for every
new event or notification type that is added.

This obviously makes getsockopt fail for binaries that are compiled
against an older versions of <net/sctp/user.h> which do not contain
all event types.

This patch changes getsockopt behaviour to no longer return an error
if not enough bytes are being provided by the user. Instead, it
returns as much of sctp_event_subscribe as fits into the provided buffer.

This leads to the new behavior that users see what they have been aware
of at compile time.

The setsockopt(..., SCTP_EVENTS, ...) API is already behaving like this.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c