]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/ddi: write ELD where it's supposed to be done
authorJani Nikula <jani.nikula@intel.com>
Mon, 27 Oct 2014 14:26:49 +0000 (16:26 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 4 Nov 2014 22:22:12 +0000 (23:22 +0100)
commiteb48a2e16c54894a1f8f43da618a0bc9d0780093
tree9418e2e5b9d1c8706462f9e00821b6ce7e4c017c
parent37536221fd2e1c327a4edaeb3ab2b6576ef1dbba
drm/i915/ddi: write ELD where it's supposed to be done

The audio programming sequence states that the ELD must be written and
enabled after the pipe is ready. Indeed, this should clarify the
situation with

commit 2ab3d14427cc8e3626306ebc5236a5dd9e28e2e3
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Wed Apr 16 16:56:09 2014 +0200

    drm/i915: Remove vblank wait from haswell_write_eld

and Ville's review of it [1].

Moreover, we should not touch the relevant registers before we get the
audio power domain.

[1] http://mid.gmane.org/20140416155309.GK18465@intel.com

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_audio.c
drivers/gpu/drm/i915/intel_ddi.c