]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 29fa5d3) | patch
dmaengine: s3c24xx-dma: make phy->irq signed for error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 7 Nov 2013 07:52:00 +0000 (10:52 +0300)
committerVinod Koul <vinod.koul@intel.com>
Tue, 11 Mar 2014 08:53:18 +0000 (14:23 +0530)
commiteb42a8c4dc5a8e91d3392bfacac736a79a53a961
tree660e439a917656637ed040a423ad26e3ea2b0d22tree | snapshot
parent29fa5d3a520cc0971b2693873d7d81d5d03497c2commit | diff
dmaengine: s3c24xx-dma: make phy->irq signed for error handling

There is a bug in s3c24xx_dma_probe() where we do:

phy->irq = platform_get_irq(pdev, i);
if (phy->irq < 0) {

The problem is that "phy->irq" is unsigned so the error handling doesn't
work.  I have changed it to signed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/s3c24xx-dma.c diff | blob | history
Linux Kernel Source Tree.