]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: sound/aoa/fabrics/layout.c: remove unneeded kfree
authorJulia Lawall <julia@diku.dk>
Sat, 20 Aug 2011 06:12:41 +0000 (08:12 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sat, 20 Aug 2011 07:27:04 +0000 (09:27 +0200)
commitea6966e37d6facc1308b97f047b1834bf739fc27
tree09c9b6f77ecb2c8e4bdd823c8748606cddf8f3d0
parentad6f64f215fcb6ef2060c55babd8c22c19c09001
ALSA: sound/aoa/fabrics/layout.c: remove unneeded kfree

The label outnodev is only used when kzalloc has not yet taken place or has
failed, so there is no need for the call for kfree under this label.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@

(
if (...) { ... when != kfree(x)
               when != x = E3
               when != E3 = x
*  return ...;
 }
... when != x = E2
    when != I(...,x,...) S
if (...) { ... when != x = E4
 kfree(x); ... return ...; }
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/aoa/fabrics/layout.c