]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: fix use after free during eDP encoder destroying
authorImre Deak <imre.deak@intel.com>
Fri, 12 Dec 2014 15:57:38 +0000 (17:57 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 16 Dec 2014 09:38:55 +0000 (10:38 +0100)
commitea5d0f8bbeba5888913f1dd29bf7ecf9e6279042
tree5747a828ea1d69d988e56477c05a54dab16f17fc
parentcbbd621efbe137ae474251d1ac97c50997e72c1f
drm/i915: fix use after free during eDP encoder destroying

After

commit 273bce0e93fa4aba189d6a368f42198a6fdbbddb
uthor: Thierry Reding <treding@nvidia.com>
Date:   Wed Dec 10 11:38:49 2014 +0100

    drm: Zero out DRM object memory upon cleanup

we will use the eDP encoder during destroying it. Fix this by calling
drm_encoder_cleanup() at a point when the encoder is not used any more.
This caused a NULL pointer dereference in pps_lock(), I can't see that
it caused any other problem.

All the other encoders seem to call drm_encoder_cleanup() at a safe
place.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c