]> git.baikalelectronics.ru Git - kernel.git/commit
mm/thp: define HPAGE_PMD_* constants as BUILD_BUG() if !THP
authorKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Tue, 25 Jun 2013 21:15:36 +0000 (14:15 -0700)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 25 Jun 2013 23:11:05 +0000 (09:11 +1000)
commitea56a500c1c68daea7eaed0fea55334f6d9ff658
treee68b37bda9d162a3806f2a4905782af658706d9c
parent9e2722339a3df916e639a6ab5234ea494ea0139f
mm/thp: define HPAGE_PMD_* constants as BUILD_BUG() if !THP

Currently, HPAGE_PMD_* constans rely on PMD_SHIFT regardless of
CONFIG_TRANSPARENT_HUGEPAGE.  PMD_SHIFT is not defined everywhere (e.g.
arm nommu case).

It means we can't use anything like this in generic code:

        if (PageTransHuge(page))
                zero_huge_user(page, 0, HPAGE_PMD_SIZE);
        else
                clear_highpage(page);

For !THP case, PageTransHuge() is 0 and compiler can eliminate
zero_huge_user() call.  But it still need to be valid C expression, means
HPAGE_PMD_SIZE has to expand to something compiler can understand.

Previously, HPAGE_PMD_* were defined to BUILD_BUG() for !THP. Let's come
back to it.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
include/linux/huge_mm.h