]> git.baikalelectronics.ru Git - kernel.git/commit
perf record: Disallow -c and -F option at the same time
authorNamhyung Kim <namhyung@kernel.org>
Fri, 2 Apr 2021 09:40:20 +0000 (18:40 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 10 May 2021 12:00:59 +0000 (09:00 -0300)
commite99e5690fccc66d471ea6f11e833b01c45186c21
treefa4a006bb836b08a46478a16532b58deb21c5f87
parentb950ad62133a7b5b98e3fd5fede72e68e2ae6495
perf record: Disallow -c and -F option at the same time

It's confusing which one is effective when the both options are given.
The current code happens to use -c in this case but users might not be
aware of it.  We can change it to complain about that instead of relying
on the implicit priority.

Before:

  $ perf record -c 111111 -F 99 true
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.031 MB perf.data (8 samples) ]

  $ perf evlist -F
  cycles: sample_period=111111
  $

After:
  $ perf record -c 111111 -F 99 true
  cannot set frequency and period at the same time
  $

So this change can break existing usages, but I think it's rare to have
both options and it'd be better changing them.

Suggested-by: Alexey Alexandrov <aalexand@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210402094020.28164-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/record.c