]> git.baikalelectronics.ru Git - kernel.git/commit
net: devlink: Fix missing mutex_unlock() call
authorAmmar Faizi <ammarfaizi2@gnuweeb.org>
Mon, 1 Aug 2022 11:59:56 +0000 (18:59 +0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 1 Aug 2022 19:47:10 +0000 (12:47 -0700)
commite7e81ed059842130930997ab98d68b0866faa747
tree0878d6785164668d3a5db1fa05d1aa0efed505f9
parentc23bf8d2a3d2e8c3bd81c5f1079a7fb4cea85557
net: devlink: Fix missing mutex_unlock() call

Commit 99cb87e2ed4e forgets to call mutex_unlock() before the function
returns in the error path:

   New smatch warnings:
   net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \
   returns '&region->snapshot_lock'.

Make sure we call mutex_unlock() in this error path.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 99cb87e2ed4e ("net: devlink: remove region snapshots list dependency on devlink->lock")
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20220801115742.1309329-1-ammar.faizi@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/devlink.c