]> git.baikalelectronics.ru Git - kernel.git/commit
net: thunderbolt: Fix error handling in tbnet_init()
authorYuan Can <yuancan@huawei.com>
Mon, 14 Nov 2022 14:22:25 +0000 (14:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Nov 2022 09:19:37 +0000 (09:19 +0000)
commite7752b0065f2b167f186d44245402efbb35e0723
treee6ff4c580166c38d79097377a0cbccb27b57b21d
parentf3c8f3b147a615b3fdaf7aff5aaaebbbe73b2528
net: thunderbolt: Fix error handling in tbnet_init()

A problem about insmod thunderbolt-net failed is triggered with following
log given while lsmod does not show thunderbolt_net:

 insmod: ERROR: could not insert module thunderbolt-net.ko: File exists

The reason is that tbnet_init() returns tb_register_service_driver()
directly without checking its return value, if tb_register_service_driver()
failed, it returns without removing property directory, resulting the
property directory can never be created later.

 tbnet_init()
   tb_register_property_dir() # register property directory
   tb_register_service_driver()
     driver_register()
       bus_add_driver()
         priv = kzalloc(...) # OOM happened
   # return without remove property directory

Fix by remove property directory when tb_register_service_driver() returns
error.

Fixes: 8231206ef815 ("net: Add support for networking over Thunderbolt cable")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/thunderbolt.c