]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: mvm: fix inactive TID removal return value usage
authorJohannes Berg <johannes.berg@intel.com>
Fri, 17 Apr 2020 07:08:14 +0000 (10:08 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 21 Apr 2020 12:39:05 +0000 (15:39 +0300)
commite6d419f943318e2b903e380dfd52a8dda6db3021
tree139ad753ea9ecfc3aa8b3331cd7fee6afbb674bf
parent38af8d5a90a8c3b41ff0484855e24bd55b43ce9d
iwlwifi: mvm: fix inactive TID removal return value usage

The function iwl_mvm_remove_inactive_tids() returns bool, so we
should just check "if (ret)", not "if (ret >= 0)" (which would
do nothing useful here). We obviously therefore cannot use the
return value of the function for the free_queue, we need to use
the queue (i) we're currently dealing with instead.

Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/iwlwifi.20200417100405.9d862ed72535.I9e27ccc3ee3c8855fc13682592b571581925dfbd@changeid
drivers/net/wireless/intel/iwlwifi/mvm/sta.c