]> git.baikalelectronics.ru Git - kernel.git/commit
platform/x86: thinkpad_acpi: Initialize local in_tablet_mode and type
authorDarren Hart <dvhart@linux.intel.com>
Wed, 14 Dec 2016 22:45:48 +0000 (14:45 -0800)
committerDarren Hart <dvhart@linux.intel.com>
Thu, 15 Dec 2016 20:31:48 +0000 (12:31 -0800)
commite6b50f584dfb276416c6784be8397cbc4263db15
treebd4292ed1a5ce326849f3aef0c870d561df38d9c
parent271ba6034663d07671e2cb6b46a261dc3cd4eb3a
platform/x86: thinkpad_acpi: Initialize local in_tablet_mode and type

linux-next reported in_tablet_mode and type may be used uninitialized
after:

5ad4afd21102 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function")

This turns out to be a false positive as the pr_info call cannot be
reached if tp_features.hotkey_tablet (global scope) is 0, and
in_tablet_mode and type are assigned in both places
tp_features.hotkey_tablet is assigned.

Regardless, to make it explicit and avoid further reports, initialize
in_tablet_mode to 0 and type to NULL.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Lyude <lyude@redhat.com>
drivers/platform/x86/thinkpad_acpi.c