]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: ext4_fill_super shouldn't return 0 on corruption
authorDarrick J. Wong <djwong@us.ibm.com>
Fri, 19 Nov 2010 14:56:44 +0000 (09:56 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 19 Nov 2010 14:56:44 +0000 (09:56 -0500)
commite6904d8347d108d94cfe74f04870939e98f1d21b
tree484c26f74f13a0c5962ac634c90462d98dea8e1a
parent139b78d246ed4f4f4d719c9b361001373fb179c1
ext4: ext4_fill_super shouldn't return 0 on corruption

At the start of ext4_fill_super, ret is set to -EINVAL, and any failure path
out of that function returns ret.  However, the generic_check_addressable
clause sets ret = 0 (if it passes), which means that a subsequent failure (e.g.
a group checksum error) returns 0 even though the mount should fail.  This
causes vfs_kern_mount in turn to think that the mount succeeded, leading to an
oops.

A simple fix is to avoid using ret for the generic_check_addressable check,
which was last changed in commit bddb8d7823ed18cd7d5ffe497b50a35c51e351ee.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/super.c