]> git.baikalelectronics.ru Git - kernel.git/commit
kasan: fix zeroing vmalloc memory with HW_TAGS
authorAndrey Konovalov <andreyknvl@google.com>
Thu, 9 Jun 2022 18:18:47 +0000 (20:18 +0200)
committerakpm <akpm@linux-foundation.org>
Mon, 4 Jul 2022 01:08:39 +0000 (18:08 -0700)
commite5d8cd1b597ab0a18d8651c53053fad7574093cd
tree31c0fc3824144a4bb907b88a8f3824e6d0f79b8c
parenta0e9976bcd5da7cda82614927d0047886487d423
kasan: fix zeroing vmalloc memory with HW_TAGS

HW_TAGS KASAN skips zeroing page_alloc allocations backing vmalloc
mappings via __GFP_SKIP_ZERO.  Instead, these pages are zeroed via
kasan_unpoison_vmalloc() by passing the KASAN_VMALLOC_INIT flag.

The problem is that __kasan_unpoison_vmalloc() does not zero pages when
either kasan_vmalloc_enabled() or is_vmalloc_or_module_addr() fail.

Thus:

1. Change __vmalloc_node_range() to only set KASAN_VMALLOC_INIT when
   __GFP_SKIP_ZERO is set.

2. Change __kasan_unpoison_vmalloc() to always zero pages when the
   KASAN_VMALLOC_INIT flag is set.

3. Add WARN_ON() asserts to check that KASAN_VMALLOC_INIT cannot be set
   in other early return paths of __kasan_unpoison_vmalloc().

Also clean up the comment in __kasan_unpoison_vmalloc.

Link: https://lkml.kernel.org/r/4bc503537efdc539ffc3f461c1b70162eea31cf6.1654798516.git.andreyknvl@google.com
Fixes: 849270667cc1 ("kasan, vmalloc: add vmalloc tagging for HW_TAGS")
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Cc: Marco Elver <elver@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/kasan/hw_tags.c
mm/vmalloc.c