]> git.baikalelectronics.ru Git - kernel.git/commit
s390/pci_mmio: fully validate the VMA before calling follow_pte()
authorDavid Hildenbrand <david@redhat.com>
Thu, 9 Sep 2021 14:59:42 +0000 (16:59 +0200)
committerVasily Gorbik <gor@linux.ibm.com>
Wed, 15 Sep 2021 12:29:21 +0000 (14:29 +0200)
commite5661e827b6b34a45b24cea98deebf5dc3360601
treeefc9ffdd54542816652aa34d9daa2b8230e375e6
parentb901123b83fca756ffcd85ea50a6cd9637d66d0c
s390/pci_mmio: fully validate the VMA before calling follow_pte()

We should not walk/touch page tables outside of VMA boundaries when
holding only the mmap sem in read mode. Evil user space can modify the
VMA layout just before this function runs and e.g., trigger races with
page table removal code since commit 4dc981eb15b2 ("mm: mmap: zap pages
with read mmap_sem in munmap").

find_vma() does not check if the address is >= the VMA start address;
use vma_lookup() instead.

Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Fixes: 4dc981eb15b2 ("mm: mmap: zap pages with read mmap_sem in munmap")
Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
arch/s390/pci/pci_mmio.c