]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vc4: kms: Use maximum FIFO load for the HVS clock rate
authorMaxime Ripard <maxime@cerno.tech>
Mon, 13 Jun 2022 14:47:30 +0000 (16:47 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Tue, 28 Jun 2022 12:54:56 +0000 (14:54 +0200)
commite4be38f7d979510e841d4d9469416df5791a33ad
tree92255aad513cd6b5b05844d95f30b5f9f3b7d037
parentcbe7dc6aa33475e7c2cc5721ac04737589ae9b27
drm/vc4: kms: Use maximum FIFO load for the HVS clock rate

The core clock computation takes into account both the load due to the
input (ie, planes) and its output (ie, encoders).

However, while the input load needs to consider all the planes, and thus
sum all of their associated loads, the output happens mostly in
parallel.

Therefore, we need to consider only the maximum of all the output loads,
and not the sum like we were doing. This resulted in a clock rate way
too high which could be discarded for being too high by the clock
framework.

Since recent changes, the clock framework will even downright reject it,
leading to a core clock being too low for its current needs.

Fixes: 8e50f5c414c6 ("drm/vc4: Increase the core clock based on HVS load")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://lore.kernel.org/r/20220613144800.326124-4-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_kms.c