]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: restore shutdown check in mapped write fault path
authorBrian Foster <bfoster@redhat.com>
Thu, 11 Feb 2021 01:27:20 +0000 (17:27 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 11 Feb 2021 01:27:20 +0000 (17:27 -0800)
commite4826691cc7e5458bcb659935d0092bcf3f08c20
tree970c4310df600a976bbf7d0dffe2d56369ebabd5
parent8e8794b919884e0a14991651a69c8a5735570d31
xfs: restore shutdown check in mapped write fault path

XFS triggers an iomap warning in the write fault path due to a
!PageUptodate() page if a write fault happens to occur on a page
that recently failed writeback. The iomap writeback error handling
code can clear the Uptodate flag if no portion of the page is
submitted for I/O. This is reproduced by fstest generic/019, which
combines various forms of I/O with simulated disk failures that
inevitably lead to filesystem shutdown (which then unconditionally
fails page writeback).

This is a regression introduced by commit f150b4234397 ("xfs: split
the iomap ops for buffered vs direct writes") due to the removal of
a shutdown check and explicit error return in the ->iomap_begin()
path used by the write fault path. The explicit error return
historically translated to a SIGBUS, but now carries on with iomap
processing where it complains about the unexpected state. Restore
the shutdown check to xfs_buffered_write_iomap_begin() to restore
historical behavior.

Fixes: f150b4234397 ("xfs: split the iomap ops for buffered vs direct writes")
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_iomap.c