]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: ipset: Fix overflow before widen in the bitmap_ip_create() function.
authorGavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Wed, 11 Jan 2023 11:57:39 +0000 (11:57 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:42:03 +0000 (11:42 +0100)
commite42438d4cb3d85632f124ee56cf3905e6cb07fbe
tree4a74438807ba3f83eab5996d50274e5f91523e2a
parent717b7123c2b207e34902caf9ffc4852bcad34df5
netfilter: ipset: Fix overflow before widen in the bitmap_ip_create() function.

commit 9ea4b476cea1b7d461d16dda25ca3c7e616e2d15 upstream.

When first_ip is 0, last_ip is 0xFFFFFFFF, and netmask is 31, the value of
an arithmetic expression 2 << (netmask - mask_bits - 1) is subject
to overflow due to a failure casting operands to a larger data type
before performing the arithmetic.

Note that it's harmless since the value will be checked at the next step.

Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Fixes: a33faf8fe585 ("netfilter: ipset: Check and reject crazy /0 input parameters")
Signed-off-by: Ilia.Gavrilov <Ilia.Gavrilov@infotecs.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/ipset/ip_set_bitmap_ip.c