]> git.baikalelectronics.ru Git - kernel.git/commit
mtip32xx: fix up the checking for internal command failure
authorJens Axboe <axboe@kernel.dk>
Fri, 23 Jun 2017 15:18:54 +0000 (09:18 -0600)
committerJens Axboe <axboe@kernel.dk>
Fri, 23 Jun 2017 15:18:54 +0000 (09:18 -0600)
commite392baee51a84713d643bf18b9d839c252d4d972
tree0778d025344fed439505041f203c94a0813be86b
parent2aa1cfce10213cc113357f5f259760015ebb9d83
mtip32xx: fix up the checking for internal command failure

This fixes up two commits that have touched this driver. The
command status field is now a blk_status_t, so we can't check
for < 0 and we definitely can't assume it's holding -Exxxx error
values. All we care about here is whether ->status is zero or not.
Check for that, and remove the various attempts at smart error
reporting. Just log to dmesg what command failed, and the
blk_status_t value.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 090700af6174 ("block: introduce new block status code type")
Fixes: 3293a09ee348 ("mtip32xx: convert internal command issue to block IO path")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/mtip32xx/mtip32xx.c