projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 45bb8d8) | patch
SUNRPC: remove pointless test in unx_match()
authorNeilBrown <neilb@suse.com>
Mon, 7 Jan 2019 06:53:52 +0000 (17:53 +1100)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Wed, 20 Feb 2019 22:33:55 +0000 (17:33 -0500)
commite3735c89985415f4fb509c67963e3d05969fbdb1
treea1420581b2399bd45c4f72c28000f23ccb22288etree | snapshot
parent45bb8d802742842fa974b0d7d474d115df1d07dbcommit | diff
SUNRPC: remove pointless test in unx_match()

As reported by Dan Carpenter, this test for acred->cred being set is
inconsistent with the dereference of the pointer a few lines earlier.

An 'auth_cred' *always* has ->cred set - every place that creates one
initializes this field, often as the first thing done.

So remove this test.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
net/sunrpc/auth_unix.c diff | blob | history
Linux Kernel Source Tree.