]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: mv88e6xxx: keep CMODE writable code private
authorVivien Didelot <vivien.didelot@gmail.com>
Wed, 28 Aug 2019 16:26:59 +0000 (12:26 -0400)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Aug 2019 00:20:25 +0000 (17:20 -0700)
commite35b3bdca4de50f774b59e4bc5ffe6ff8002280d
treed4ab6a1bcab0a1f86992b2fafc6dc6fb0bb7507e
parentd640b25b4ea0a5f5a944a242c57398fc79bc07d4
net: dsa: mv88e6xxx: keep CMODE writable code private

This is a follow-up patch for commit 5a2edc8a6943 ("net: dsa:
mv88e6xxx: fully support SERDES on Topaz family").

Since .port_set_cmode is only called from mv88e6xxx_port_setup_mac and
mv88e6xxx_phylink_mac_config, it is fine to keep this "make writable"
code private to the mv88e6341_port_set_cmode implementation, instead
of adding yet another operation to the switch info structure.

Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
Reviewed-by: Marek BehĂșn <marek.behun@nic.cz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c
drivers/net/dsa/mv88e6xxx/chip.h
drivers/net/dsa/mv88e6xxx/port.c
drivers/net/dsa/mv88e6xxx/port.h