]> git.baikalelectronics.ru Git - kernel.git/commit
can: isotp: remove re-binding of bound socket
authorOliver Hartkopp <socketcan@hartkopp.net>
Fri, 22 Apr 2022 08:23:37 +0000 (10:23 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 29 Apr 2022 09:02:47 +0000 (11:02 +0200)
commite2e88b7952b5892049a096a5230b9eae36247cea
treed497c068bed11bef7d6c2a8f9263a00b6259ff0c
parent831d3dc72da16aaf6aa4ff0727f9352f5f6e1643
can: isotp: remove re-binding of bound socket

As a carry over from the CAN_RAW socket (which allows to change the CAN
interface while mantaining the filter setup) the re-binding of the
CAN_ISOTP socket needs to take care about CAN ID address information and
subscriptions. It turned out that this feature is so limited (e.g. the
sockopts remain fix) that it finally has never been needed/used.

In opposite to the stateless CAN_RAW socket the switching of the CAN ID
subscriptions might additionally lead to an interrupted ongoing PDU
reception. So better remove this unneeded complexity.

Fixes: 28da5a05c8c3 ("can: add ISO 15765-2:2016 transport protocol")
Link: https://lore.kernel.org/all/20220422082337.1676-1-socketcan@hartkopp.net
Cc: stable@vger.kernel.org
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/isotp.c