]> git.baikalelectronics.ru Git - kernel.git/commit
ipv6: sr: fix useless rol32 call on hash
authorColin Ian King <colin.king@canonical.com>
Tue, 17 Jul 2018 15:52:54 +0000 (16:52 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Jul 2018 22:10:47 +0000 (15:10 -0700)
commite2cca7616ecd9b704a06eb972c914c657d7ccab3
tree8c13bb5797268e4fadaa6bd12a2b9fa96be99aa5
parent7c3f1a3f3fba253d92fc56ce1c7ff0fd9b514a1c
ipv6: sr: fix useless rol32 call on hash

The rol32 call is currently rotating hash but the rol'd value is
being discarded. I believe the current code is incorrect and hash
should be assigned the rotated value returned from rol32.

Detected by CoverityScan, CID#1468411 ("Useless call")

Fixes: adfbb4291a1f ("ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: dlebrun@google.com
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/seg6_iptunnel.c