]> git.baikalelectronics.ru Git - kernel.git/commit
[media] zc3xx: Remove deprecated create_singlethread_workqueue
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Sat, 9 Jul 2016 07:52:29 +0000 (04:52 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 9 Jul 2016 10:43:53 +0000 (07:43 -0300)
commite28076a33be05c28c0db9e5bdfe7018692dc4517
treebfec4efc155c746eb761da8d409162dddee4bdf2
parent8b3b81afc14fef8a66f8277027befb90cd0be0b3
[media] zc3xx: Remove deprecated create_singlethread_workqueue

The workqueue "work_thread" is involved in updating parameters for
transfers. It has a single work item(&sd->work) and hence
doesn't require ordering. Also, it is not being used on a memory
reclaim path. Hence, the singlethreaded workqueue has been replaced with
the use of system_wq.

System workqueues have been able to handle high level of concurrency
for a long time now and hence it's not required to have a singlethreaded
workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
created with create_singlethread_workqueue(), system_wq allows multiple
work items to overlap executions even on the same CPU; however, a
per-cpu workqueue doesn't have any CPU locality or global ordering
guarantee unless the target CPU is explicitly specified and thus the
increase of local concurrency shouldn't make any difference.

Work item has been flushed in sd_stop0() to ensure that there are no
pending tasks while disconnecting the driver.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/gspca/zc3xx.c