]> git.baikalelectronics.ru Git - kernel.git/commit
drm/mediatek: fix OF sibling-node lookup
authorJohan Hovold <johan@kernel.org>
Mon, 27 Aug 2018 08:21:46 +0000 (10:21 +0200)
committerRob Herring <robh@kernel.org>
Tue, 23 Oct 2018 18:19:58 +0000 (13:19 -0500)
commite27ecde49929b18ee81c32e8dac07cfc7806026f
treefd74d5204ed643fed7316af8001bd08cb0ed0f6c
parentcb338634a7cd447c03cfe45c891112c10f5c4f3e
drm/mediatek: fix OF sibling-node lookup

Use the new of_get_compatible_child() helper to lookup the sibling
instead of using of_find_compatible_node(), which searches the entire
tree from a given start node and thus can return an unrelated (i.e.
non-sibling) node.

This also addresses a potential use-after-free (e.g. after probe
deferral) as the tree-wide helper drops a reference to its first
argument (i.e. the parent device node).

While at it, also fix the related cec-node reference leak.

Fixes: 98b4e84d5174 ("drm/mediatek: Add HDMI support")
Cc: stable <stable@vger.kernel.org> # 4.8
Cc: Junzhi Zhao <junzhi.zhao@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: CK Hu <ck.hu@mediatek.com>
Cc: David Airlie <airlied@linux.ie>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/gpu/drm/mediatek/mtk_hdmi.c