]> git.baikalelectronics.ru Git - kernel.git/commit
fixup! wil6210: fix usage of print_hex_dump_debug
authorVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Sun, 14 Sep 2014 08:14:10 +0000 (11:14 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 15 Sep 2014 19:00:53 +0000 (15:00 -0400)
commite23b6fecb53242aececd4db3d33a313d6b64aa23
tree508d0a9be50a7c2fe959c1de1ad60faaff3af81e
parentb1df779c102897aaacbbee13968e59946a1e7ed1
fixup! wil6210: fix usage of print_hex_dump_debug

Use empty inline functions instead of empty #define. Fix for "unused variable"
as reported below:

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master
head:   b9fbae9797d92d289f73ec06272b1f5a4c6d7af0
commit: d196681d22cf28e647ff37b80121a9c6ae715500 [45/62] wil6210: fix usage of print_hex_dump_debug
config: i386-allyesconfig
reproduce:
  git checkout d196681d22cf28e647ff37b80121a9c6ae715500
  make ARCH=i386  allyesconfig
  make ARCH=i386

All warnings:

   drivers/net/wireless/ath/wil6210/wmi.c: In function 'wmi_evt_rx_mgmt':

>> drivers/net/wireless/ath/wil6210/wmi.c:341:10: warning: unused variable 'ie_len' [-Wunused-variable]
      size_t ie_len = d_len - offsetof(struct ieee80211_mgmt,
             ^

>> drivers/net/wireless/ath/wil6210/wmi.c:340:13: warning: unused variable 'ie_buf' [-Wunused-variable]
      const u8 *ie_buf = rx_mgmt_frame->u.beacon.variable;
                ^

vim +/ie_len +341 drivers/net/wireless/ath/wil6210/wmi.c

8b8a3964 Vladimir Kondratiev 2012-12-20  334
8b8a3964 Vladimir Kondratiev 2012-12-20  335    if (ieee80211_is_beacon(fc) || ieee80211_is_probe_resp(fc)) {
8b8a3964 Vladimir Kondratiev 2012-12-20  336            struct cfg80211_bss *bss;
32773e11 Vladimir Kondratiev 2014-06-16  337            u64 tsf = le64_to_cpu(rx_mgmt_frame->u.beacon.timestamp);
32773e11 Vladimir Kondratiev 2014-06-16  338            u16 cap = le16_to_cpu(rx_mgmt_frame->u.beacon.capab_info);
32773e11 Vladimir Kondratiev 2014-06-16  339            u16 bi = le16_to_cpu(rx_mgmt_frame->u.beacon.beacon_int);
32773e11 Vladimir Kondratiev 2014-06-16  340            const u8 *ie_buf = rx_mgmt_frame->u.beacon.variable;
32773e11 Vladimir Kondratiev 2014-06-16  341            size_t ie_len = d_len - offsetof(struct ieee80211_mgmt,
32773e11 Vladimir Kondratiev 2014-06-16  342                                             u.beacon.variable);
32773e11 Vladimir Kondratiev 2014-06-16  343            wil_dbg_wmi(wil, "Capability info : 0x%04x\n", cap);
32773e11 Vladimir Kondratiev 2014-06-16  344            wil_dbg_wmi(wil, "TSF : 0x%016llx\n", tsf);

:::::: The code at line 341 was first introduced by commit
:::::: 32773e110da062a5587d771f6a6dbfa598b8d07d wil6210: print more info about BSS found

Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/wil6210/wil6210.h