]> git.baikalelectronics.ru Git - kernel.git/commit
tmpfs: fix regression hang in fallocate undo
authorHugh Dickins <hughd@google.com>
Sun, 10 Jul 2016 23:46:32 +0000 (16:46 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 11 Jul 2016 03:08:44 +0000 (20:08 -0700)
commite1ff6d72b68fbdc6f6e363cf8ab9fb6f8e9f8b89
tree020fc68e31c9361c49786606a819dc5be9a2a8a6
parent1e0228c80461f7eae192cc0676c6edfe3f79ed1c
tmpfs: fix regression hang in fallocate undo

The well-spotted fallocate undo fix is good in most cases, but not when
fallocate failed on the very first page.  index 0 then passes lend -1
to shmem_undo_range(), and that has two bad effects: (a) that it will
undo every fallocation throughout the file, unrestricted by the current
range; but more importantly (b) it can cause the undo to hang, because
lend -1 is treated as truncation, which makes it keep on retrying until
every page has gone, but those already fully instantiated will never go
away.  Big thank you to xfstests generic/269 which demonstrates this.

Fixes: 47b7a2c5f99e ("tmpfs: don't undo fallocate past its last page")
Cc: stable@vger.kernel.org
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/shmem.c