]> git.baikalelectronics.ru Git - kernel.git/commit
leds: core: Fix regression caused by commit 8a17677ae3be
authorJacek Anaszewski <jacek.anaszewski@gmail.com>
Wed, 3 Jan 2018 20:13:45 +0000 (21:13 +0100)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Sun, 7 Jan 2018 12:27:07 +0000 (13:27 +0100)
commite1d5ba6164a48697cda08a805a1d0b34524e6617
tree0794a662a2854b2c8bc46adb048f8b88a515f86d
parent6ebfdc2edb3a84fa6b52ee806b0bc6b765b33b3e
leds: core: Fix regression caused by commit 8a17677ae3be

Commit 8a17677ae3be ("led: core: Fix brightness setting when setting delay_off=0")
replaced del_timer_sync(&led_cdev->blink_timer) with led_stop_software_blink()
in led_blink_set(), which additionally clears LED_BLINK_SW flag as well as
zeroes blink_delay_on and blink_delay_off properties of the struct led_classdev.

Cleansing of the latter ones wasn't required to fix the original issue but
wasn't considered harmful. It nonetheless turned out to be so in case when
pointer to one or both props is passed to led_blink_set() like in the
ledtrig-timer.c. In such cases zeroes are passed later in delay_on and/or
delay_off arguments to led_blink_setup(), which results either in stopping
the software blinking or setting blinking frequency always to 1Hz.

Avoid using led_stop_software_blink() and add a single call required
to clear LED_BLINK_SW flag, which was the only needed modification to
fix the original issue.

Fixes 8a17677ae3be ("led: core: Fix brightness setting when setting delay_off=0")
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/led-core.c