]> git.baikalelectronics.ru Git - kernel.git/commit
mellanox: mlx5: avoid uninitialized variable warning with gcc-12
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 9 Jun 2022 17:03:28 +0000 (10:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 9 Jun 2022 17:03:28 +0000 (10:03 -0700)
commite187f6f1aa94fecf11e726b73fe6f6489a089040
treeb799b2ed574a7bd685e3e991116157eadb3f99b1
parent999e5531abb834fd683145bf455ec7ef3ec3d253
mellanox: mlx5: avoid uninitialized variable warning with gcc-12

gcc-12 started warning about 'tracker' being used uninitialized:

  drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c: In function ‘mlx5_do_bond’:
  drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:786:28: warning: ‘tracker’ is used uninitialized [-Wuninitialized]
    786 |         struct lag_tracker tracker;
        |                            ^~~~~~~

which seems to be because it doesn't track how the use (and
initialization) is bound by the 'do_bond' flag.

But admittedly that 'do_bond' usage is fairly complicated, and involves
passing it around as an argument to helper functions, so it's somewhat
understandable that gcc doesn't see how that all works.

This function could be rewritten to make the use of that tracker
variable more obviously safe, but for now I'm just adding the forced
initialization of it.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c