]> git.baikalelectronics.ru Git - kernel.git/commit
drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY
authorDavid Rivshin <drivshin@allworx.com>
Thu, 17 Dec 2015 04:02:10 +0000 (23:02 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Dec 2015 19:46:05 +0000 (14:46 -0500)
commite1061923ca1ed8e5de2111598753f0e57f1a23cb
treec2c7b0b3aeeb9410ac2dd1ef6c14055bd0e9c139
parent586bf85c3290f7e23a3518c7bd70008ca43bd2ab
drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

Commit a484b68f64d3dcdd2127878bb229e4dacf811b1b ("drivers: net: cpsw: Add
support for fixed-link PHY") did not parse the "phy-mode" property in
the case of a fixed-link PHY, leaving slave_data->phy_if with its default
of PHY_INTERFACE_MODE_NA(0). This later gets passed to phy_connect() in
cpsw_slave_open(), and eventually to cpsw_phy_sel() where it hits a default
case that configures the MAC for MII mode.

The user visible symptom is that while kernel log messages seem to indicate
that the interface is set up, there is no network communication. Eventually
a watchdog error occurs:
    NETDEV WATCHDOG: eth0 (cpsw): transmit queue 0 timed out

Fixes: a484b68f64d3 ("drivers: net: cpsw: Add support for fixed-link PHY")
Signed-off-by: David Rivshin <drivshin@allworx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/devicetree/bindings/net/cpsw.txt
drivers/net/ethernet/ti/cpsw.c