]> git.baikalelectronics.ru Git - kernel.git/commit
NFC: pn533: fix bulk-message timeout
authorJohan Hovold <johan@kernel.org>
Mon, 13 Jan 2020 17:23:58 +0000 (18:23 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 14 Jan 2020 02:50:18 +0000 (18:50 -0800)
commite0e2754603d3fa8746d45944c4ad0261698cfd09
tree9fbf7e1efb2a2a873c30efe26e760d43260242bd
parentc5cbbee0270f89c56fc37627ca82e0aa096e9d9a
NFC: pn533: fix bulk-message timeout

The driver was doing a synchronous uninterruptible bulk-transfer without
using a timeout. This could lead to the driver hanging on probe due to a
malfunctioning (or malicious) device until the device is physically
disconnected. While sleeping in probe the driver prevents other devices
connected to the same hub from being added to (or removed from) the bus.

An arbitrary limit of five seconds should be more than enough.

Fixes: 4ee0926afbff ("NFC: pn533: don't send USB data off of the stack")
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/pn533/usb.c